monoadmin/the-other-dude
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: resolve review issues in DeviceLink rollout

Browse Source 
- Fix import casing in AuditLogTable (DeviceLink → device-link)
- Remove DeviceLink from BatchConfigPanel device selector (nested interactive)
- Remove DeviceLink from TemplatePushWizard device selector (nested interactive)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jason Staack
2026-03-18 11:28:17 -05:00
parent 98c45d92ce
commit fee40db073
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/components/audit/AuditLogTable.tsx
View File

@@ -22,7 +22,7 @@ import {
type AuditLogParams, type AuditLogParams,
} from '@/lib/api' } from '@/lib/api'
import { cn } from '@/lib/utils' import { cn } from '@/lib/utils'
import { DeviceLink } from '@/components/ui/DeviceLink' import { DeviceLink } from '@/components/ui/device-link'
import { EmptyState } from '@/components/ui/empty-state' import { EmptyState } from '@/components/ui/empty-state'
// Predefined action types for the filter dropdown // Predefined action types for the filter dropdown

2
frontend/src/components/config/BatchConfigPanel.tsx
View File

@@ -243,7 +243,7 @@ function DeviceSelector({
/> />
</td> </td>
<td className="px-3 py-2 font-medium"> <td className="px-3 py-2 font-medium">
<DeviceLink tenantId={tenantId} deviceId={device.id}>{device.hostname}</DeviceLink> {device.hostname}
</td> </td>
<td className="px-3 py-2 font-mono text-text-secondary">{device.ip_address}</td> <td className="px-3 py-2 font-mono text-text-secondary">{device.ip_address}</td>
<td className="px-3 py-2"> <td className="px-3 py-2">

3
frontend/src/components/templates/TemplatePushWizard.tsx
View File

@@ -29,7 +29,6 @@ import {
type TemplateResponse, type TemplateResponse,
} from '@/lib/templatesApi' } from '@/lib/templatesApi'
import { deviceGroupsApi, metricsApi } from '@/lib/api' import { deviceGroupsApi, metricsApi } from '@/lib/api'
import { DeviceLink } from '@/components/ui/device-link'
import { PushProgressPanel } from './PushProgressPanel' import { PushProgressPanel } from './PushProgressPanel'
interface TemplatePushWizardProps { interface TemplatePushWizardProps {
@@ -201,7 +200,7 @@ export function TemplatePushWizard({ open, onClose, tenantId, template }: Templa
onCheckedChange={() => toggleDevice(device.id)} onCheckedChange={() => toggleDevice(device.id)}
/> />
<div className="flex-1 min-w-0"> <div className="flex-1 min-w-0">
<div className="text-xs text-text-primary truncate"><DeviceLink tenantId={tenantId} deviceId={device.id}>{device.hostname}</DeviceLink></div> <div className="text-xs text-text-primary truncate">{device.hostname}</div>
<div className="text-[10px] text-text-muted">{device.ip_address}</div> <div className="text-[10px] text-text-muted">{device.ip_address}</div>
</div> </div>
<div <div