monoadmin/the-other-dude
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove dead code (toast stubs, unused Redis key, tunnel manager fields)

Browse Source 
- Remove 7 no-op exported stubs from toast.tsx (ToastProvider, ToastViewport,
  Toast, ToastTitle, ToastDescription, ToastClose, useToasts) — nothing imports them
- Remove fwFailKey variable and its Set() call from worker.go — the
  firmware:check-failed Redis key was never read anywhere
- Remove unused deviceStore and credCache fields from tunnel.Manager struct
  and drop corresponding parameters from NewManager(); update call site in
  main.go and all test usages

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Jason Staack
2026-03-15 23:12:56 -05:00
parent 83e59ed8d7
commit f49f5f739b
5 changed files with 16 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
poller/internal/tunnel/manager_test.go
View File

@@ -12,7 +12,7 @@ func TestManager_OpenTunnel(t *testing.T) {
routerAddr, cleanup := mockRouter(t)
defer cleanup()
mgr := NewManager(49000, 49010, 5*time.Minute, nil, nil)
mgr := NewManager(49000, 49010, 5*time.Minute)
defer mgr.Shutdown()
resp, err := mgr.OpenTunnel("dev-1", "ten-1", "usr-1", routerAddr)
@@ -26,7 +26,7 @@ func TestManager_CloseTunnel(t *testing.T) {
routerAddr, cleanup := mockRouter(t)
defer cleanup()
mgr := NewManager(49000, 49010, 5*time.Minute, nil, nil)
mgr := NewManager(49000, 49010, 5*time.Minute)
defer mgr.Shutdown()
resp, _ := mgr.OpenTunnel("dev-1", "ten-1", "usr-1", routerAddr)
@@ -43,7 +43,7 @@ func TestManager_PortExhaustion(t *testing.T) {
routerAddr, cleanup := mockRouter(t)
defer cleanup()
mgr := NewManager(49000, 49001, 5*time.Minute, nil, nil) // 2 ports
mgr := NewManager(49000, 49001, 5*time.Minute) // 2 ports
defer mgr.Shutdown()
_, err := mgr.OpenTunnel("dev-1", "ten-1", "usr-1", routerAddr)
@@ -58,7 +58,7 @@ func TestManager_IdleCleanup(t *testing.T) {
routerAddr, cleanup := mockRouter(t)
defer cleanup()
mgr := NewManager(49000, 49010, 100*time.Millisecond, nil, nil) // very short idle
mgr := NewManager(49000, 49010, 100*time.Millisecond) // very short idle
defer mgr.Shutdown()
resp, _ := mgr.OpenTunnel("dev-1", "ten-1", "usr-1", routerAddr)
@@ -73,7 +73,7 @@ func TestManager_StatusList(t *testing.T) {
routerAddr, cleanup := mockRouter(t)
defer cleanup()
mgr := NewManager(49000, 49010, 5*time.Minute, nil, nil)
mgr := NewManager(49000, 49010, 5*time.Minute)
defer mgr.Shutdown()
mgr.OpenTunnel("dev-1", "ten-1", "usr-1", routerAddr)