From 998fff7d0124d4f087d1e5c609ef42e185931564 Mon Sep 17 00:00:00 2001
From: Jason Staack <jason@staack.com>
Date: Sat, 21 Mar 2026 18:57:50 -0500
Subject: [PATCH] feat(17-03): add bulk add schemas for credential profile
 support

- BulkAddWithProfileRequest with credential_profile_id, device_type, defaults
- BulkAddDeviceEntry with IP address validation
- BulkAddDefaults for type-appropriate port/TLS defaults
- BulkAddDeviceResult and BulkAddWithProfileResult for per-device reporting
- Existing BulkAddRequest preserved for backward compatibility

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 backend/app/schemas/device.py | 80 +++++++++++++++++++++++++++++++++++
 1 file changed, 80 insertions(+)

diff --git a/backend/app/schemas/device.py b/backend/app/schemas/device.py
index 6c04c49..b9d236e 100644
--- a/backend/app/schemas/device.py
+++ b/backend/app/schemas/device.py
@@ -196,6 +196,86 @@ class BulkAddResult(BaseModel):
     failed: list[dict]  # {ip_address, error}
 
 
+# ---------------------------------------------------------------------------
+# Credential-profile bulk add
+# ---------------------------------------------------------------------------
+
+
+class BulkAddDeviceEntry(BaseModel):
+    """One device entry in the credential-profile bulk add."""
+
+    ip_address: str
+    hostname: Optional[str] = None  # defaults to IP if not provided
+
+    @field_validator("ip_address")
+    @classmethod
+    def validate_ip(cls, v: str) -> str:
+        import ipaddress
+
+        try:
+            ipaddress.ip_address(v.strip())
+        except ValueError as e:
+            raise ValueError(f"Invalid IP address: {e}") from e
+        return v.strip()
+
+
+class BulkAddDefaults(BaseModel):
+    """Default values applied to all devices in bulk add unless overridden."""
+
+    # RouterOS defaults
+    api_port: int = 8728
+    api_ssl_port: int = 8729
+    tls_mode: str = "auto"
+    # SNMP defaults
+    snmp_port: int = 161
+    snmp_version: Optional[str] = None  # "v1", "v2c", "v3"
+    snmp_profile_id: Optional[uuid.UUID] = None
+
+
+class BulkAddWithProfileRequest(BaseModel):
+    """Bulk-add devices using a credential profile."""
+
+    credential_profile_id: uuid.UUID
+    device_type: str = "routeros"  # "routeros" or "snmp"
+    defaults: Optional[BulkAddDefaults] = None
+    devices: list[BulkAddDeviceEntry]
+
+    @field_validator("device_type")
+    @classmethod
+    def validate_device_type(cls, v: str) -> str:
+        if v not in ("routeros", "snmp"):
+            raise ValueError("device_type must be 'routeros' or 'snmp'")
+        return v
+
+    @field_validator("devices")
+    @classmethod
+    def validate_devices_not_empty(cls, v: list) -> list:
+        if not v:
+            raise ValueError("devices list must not be empty")
+        if len(v) > 500:
+            raise ValueError("Maximum 500 devices per bulk add request")
+        return v
+
+
+class BulkAddDeviceResult(BaseModel):
+    """Result for a single device in bulk add."""
+
+    ip_address: str
+    hostname: Optional[str] = None
+    success: bool
+    device_id: Optional[uuid.UUID] = None
+    error: Optional[str] = None
+
+
+class BulkAddWithProfileResult(BaseModel):
+    """Result of a credential-profile bulk add operation."""
+
+    total: int
+    succeeded: int
+    failed: int
+    results: list[BulkAddDeviceResult]
+
+
 # ---------------------------------------------------------------------------
 # DeviceGroup schemas
 # ---------------------------------------------------------------------------