monoadmin/the-other-dude
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review — ref init, title bar padding, a11y labeling

Browse Source 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jason Staack
2026-03-19 13:09:34 -05:00
parent 11a91898d4
commit 6c9a532dfe
1 changed files with 4 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
frontend/src/components/about/AnsiNfoModal.tsx
View File

@@ -87,12 +87,8 @@ interface AnsiNfoModalProps {
export function AnsiNfoModal({ open, onOpenChange }: AnsiNfoModalProps) { export function AnsiNfoModal({ open, onOpenChange }: AnsiNfoModalProps) {
const [visibleLines, setVisibleLines] = useState(0) const [visibleLines, setVisibleLines] = useState(0)
const [animationDone, setAnimationDone] = useState(false) const [animationDone, setAnimationDone] = useState(false)
const linesRef = useRef<ArtLine[]>([]) const linesRef = useRef<ArtLine[]>(buildNfoLines())
const intervalRef = useRef<ReturnType<typeof setInterval> | null>(null) const intervalRef = useRef<ReturnType<typeof setInterval> | null>(null)
if (linesRef.current.length === 0) {
linesRef.current = buildNfoLines()
}
const totalLines = linesRef.current.length const totalLines = linesRef.current.length
const skipAnimation = useCallback(() => { const skipAnimation = useCallback(() => {
@@ -151,8 +147,8 @@ export function AnsiNfoModal({ open, onOpenChange }: AnsiNfoModalProps) {
}} }}
> >
{/* Retro title bar */} {/* Retro title bar */}
<div className="flex items-center justify-between px-3 py-1.5 bg-surface border-b border-border font-mono text-xs"> <div className="flex items-center justify-between px-3 pr-10 py-1.5 bg-surface border-b border-border font-mono text-xs">
<DialogTitle className="text-text-muted text-xs font-normal font-mono"> <DialogTitle id="ansi-nfo-title" className="text-text-muted text-xs font-normal font-mono">
TOD.NFO — ACiD View v1.0 TOD.NFO — ACiD View v1.0
</DialogTitle> </DialogTitle>
</div> </div>
@@ -161,6 +157,7 @@ export function AnsiNfoModal({ open, onOpenChange }: AnsiNfoModalProps) {
<div <div
className="overflow-y-auto p-4 max-h-[70vh] font-mono text-[10px] sm:text-xs md:text-sm leading-relaxed" className="overflow-y-auto p-4 max-h-[70vh] font-mono text-[10px] sm:text-xs md:text-sm leading-relaxed"
role="document" role="document"
aria-labelledby="ansi-nfo-title"
> >
<pre className="whitespace-pre" aria-hidden="true"> <pre className="whitespace-pre" aria-hidden="true">
{linesRef.current.slice(0, visibleLines).map(([cls, text], i) => ( {linesRef.current.slice(0, visibleLines).map(([cls, text], i) => (