feat(17-01): add CredentialProfile model and Pydantic schemas
- SQLAlchemy model mapping to credential_profiles table (migration 037) - CredentialProfileCreate with model_validator enforcing per-type required fields - CredentialProfileUpdate with conditional validation on type change - CredentialProfileResponse without any credential fields (write-only) - Device model updated with credential_profile_id FK and relationship Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
55
backend/app/models/credential_profile.py
Normal file
55
backend/app/models/credential_profile.py
Normal file
@@ -0,0 +1,55 @@
|
||||
"""CredentialProfile model -- reusable credential sets for devices."""
|
||||
|
||||
import uuid
|
||||
from datetime import datetime
|
||||
|
||||
from sqlalchemy import DateTime, ForeignKey, LargeBinary, String, Text, UniqueConstraint, func
|
||||
from sqlalchemy.dialects.postgresql import UUID
|
||||
from sqlalchemy.orm import Mapped, mapped_column, relationship
|
||||
|
||||
from app.models.base import Base
|
||||
|
||||
|
||||
class CredentialProfile(Base):
|
||||
__tablename__ = "credential_profiles"
|
||||
__table_args__ = (
|
||||
UniqueConstraint("tenant_id", "name", name="uq_credential_profiles_tenant_name"),
|
||||
)
|
||||
|
||||
id: Mapped[uuid.UUID] = mapped_column(
|
||||
UUID(as_uuid=True),
|
||||
primary_key=True,
|
||||
default=uuid.uuid4,
|
||||
server_default=func.gen_random_uuid(),
|
||||
)
|
||||
tenant_id: Mapped[uuid.UUID] = mapped_column(
|
||||
UUID(as_uuid=True),
|
||||
ForeignKey("tenants.id", ondelete="CASCADE"),
|
||||
nullable=False,
|
||||
index=True,
|
||||
)
|
||||
name: Mapped[str] = mapped_column(String(255), nullable=False)
|
||||
description: Mapped[str | None] = mapped_column(Text, nullable=True)
|
||||
credential_type: Mapped[str] = mapped_column(String(50), nullable=False)
|
||||
encrypted_credentials: Mapped[bytes | None] = mapped_column(LargeBinary, nullable=True)
|
||||
encrypted_credentials_transit: Mapped[str | None] = mapped_column(Text, nullable=True)
|
||||
created_at: Mapped[datetime] = mapped_column(
|
||||
DateTime(timezone=True), server_default=func.now(), nullable=False
|
||||
)
|
||||
updated_at: Mapped[datetime] = mapped_column(
|
||||
DateTime(timezone=True), server_default=func.now(), onupdate=func.now(), nullable=False
|
||||
)
|
||||
|
||||
# Relationships
|
||||
tenant: Mapped["Tenant"] = relationship("Tenant") # type: ignore[name-defined]
|
||||
devices: Mapped[list["Device"]] = relationship( # type: ignore[name-defined]
|
||||
"Device",
|
||||
back_populates="credential_profile",
|
||||
foreign_keys="[Device.credential_profile_id]",
|
||||
)
|
||||
|
||||
def __repr__(self) -> str:
|
||||
return (
|
||||
f"<CredentialProfile id={self.id} name={self.name!r}"
|
||||
f" type={self.credential_type!r} tenant_id={self.tenant_id}>"
|
||||
)
|
||||
@@ -117,6 +117,17 @@ class Device(Base):
|
||||
sector: Mapped["Sector"] = relationship( # type: ignore[name-defined]
|
||||
"Sector", back_populates="devices", foreign_keys=[sector_id]
|
||||
)
|
||||
credential_profile_id: Mapped[uuid.UUID | None] = mapped_column(
|
||||
UUID(as_uuid=True),
|
||||
ForeignKey("credential_profiles.id", ondelete="SET NULL"),
|
||||
nullable=True,
|
||||
index=True,
|
||||
)
|
||||
credential_profile: Mapped["CredentialProfile"] = relationship( # type: ignore[name-defined]
|
||||
"CredentialProfile",
|
||||
back_populates="devices",
|
||||
foreign_keys=[credential_profile_id],
|
||||
)
|
||||
|
||||
def __repr__(self) -> str:
|
||||
return f"<Device id={self.id} hostname={self.hostname!r} tenant_id={self.tenant_id}>"
|
||||
|
||||
223
backend/app/schemas/credential_profile.py
Normal file
223
backend/app/schemas/credential_profile.py
Normal file
@@ -0,0 +1,223 @@
|
||||
"""Pydantic schemas for CredentialProfile endpoints."""
|
||||
|
||||
import uuid
|
||||
from datetime import datetime
|
||||
from typing import Optional
|
||||
|
||||
from pydantic import BaseModel, field_validator, model_validator
|
||||
|
||||
|
||||
VALID_CREDENTIAL_TYPES = ("routeros", "snmp_v1", "snmp_v2c", "snmp_v3")
|
||||
VALID_SECURITY_LEVELS = ("no_auth_no_priv", "auth_no_priv", "auth_priv")
|
||||
VALID_AUTH_PROTOCOLS = ("SHA256", "SHA384", "SHA512")
|
||||
VALID_PRIV_PROTOCOLS = ("AES128", "AES256")
|
||||
|
||||
|
||||
class CredentialProfileCreate(BaseModel):
|
||||
"""Schema for creating a credential profile."""
|
||||
|
||||
name: str
|
||||
description: Optional[str] = None
|
||||
credential_type: str
|
||||
|
||||
# RouterOS credential fields
|
||||
username: Optional[str] = None
|
||||
password: Optional[str] = None
|
||||
|
||||
# SNMP v1/v2c credential fields
|
||||
community: Optional[str] = None
|
||||
|
||||
# SNMP v3 credential fields
|
||||
security_level: Optional[str] = None
|
||||
auth_protocol: Optional[str] = None
|
||||
auth_passphrase: Optional[str] = None
|
||||
priv_protocol: Optional[str] = None
|
||||
priv_passphrase: Optional[str] = None
|
||||
|
||||
@field_validator("name")
|
||||
@classmethod
|
||||
def validate_name(cls, v: str) -> str:
|
||||
v = v.strip()
|
||||
if len(v) < 1 or len(v) > 255:
|
||||
raise ValueError("Profile name must be 1-255 characters")
|
||||
return v
|
||||
|
||||
@field_validator("credential_type")
|
||||
@classmethod
|
||||
def validate_credential_type(cls, v: str) -> str:
|
||||
if v not in VALID_CREDENTIAL_TYPES:
|
||||
raise ValueError(
|
||||
f"credential_type must be one of: {', '.join(VALID_CREDENTIAL_TYPES)}"
|
||||
)
|
||||
return v
|
||||
|
||||
@model_validator(mode="after")
|
||||
def validate_credentials(self) -> "CredentialProfileCreate":
|
||||
"""Validate required credential fields based on credential_type."""
|
||||
ct = self.credential_type
|
||||
if ct == "routeros":
|
||||
if not self.username:
|
||||
raise ValueError("username is required for routeros credentials")
|
||||
if not self.password:
|
||||
raise ValueError("password is required for routeros credentials")
|
||||
elif ct in ("snmp_v1", "snmp_v2c"):
|
||||
if not self.community:
|
||||
raise ValueError(f"community is required for {ct} credentials")
|
||||
elif ct == "snmp_v3":
|
||||
if not self.username:
|
||||
raise ValueError("username is required for snmp_v3 credentials")
|
||||
if not self.security_level:
|
||||
raise ValueError("security_level is required for snmp_v3 credentials")
|
||||
if self.security_level not in VALID_SECURITY_LEVELS:
|
||||
raise ValueError(
|
||||
f"security_level must be one of: {', '.join(VALID_SECURITY_LEVELS)}"
|
||||
)
|
||||
# auth fields required if security_level includes auth
|
||||
if "auth" in self.security_level and self.security_level != "no_auth_no_priv":
|
||||
if not self.auth_protocol:
|
||||
raise ValueError(
|
||||
"auth_protocol is required when security_level includes authentication"
|
||||
)
|
||||
if self.auth_protocol not in VALID_AUTH_PROTOCOLS:
|
||||
raise ValueError(
|
||||
f"auth_protocol must be one of: {', '.join(VALID_AUTH_PROTOCOLS)}"
|
||||
)
|
||||
if not self.auth_passphrase:
|
||||
raise ValueError(
|
||||
"auth_passphrase is required when security_level includes authentication"
|
||||
)
|
||||
# priv fields required if security_level includes priv
|
||||
if "priv" in self.security_level and self.security_level != "no_auth_no_priv":
|
||||
if self.security_level == "auth_priv":
|
||||
if not self.priv_protocol:
|
||||
raise ValueError(
|
||||
"priv_protocol is required when security_level is auth_priv"
|
||||
)
|
||||
if self.priv_protocol not in VALID_PRIV_PROTOCOLS:
|
||||
raise ValueError(
|
||||
f"priv_protocol must be one of: {', '.join(VALID_PRIV_PROTOCOLS)}"
|
||||
)
|
||||
if not self.priv_passphrase:
|
||||
raise ValueError(
|
||||
"priv_passphrase is required when security_level is auth_priv"
|
||||
)
|
||||
return self
|
||||
|
||||
|
||||
class CredentialProfileUpdate(BaseModel):
|
||||
"""Schema for updating a credential profile. All fields optional."""
|
||||
|
||||
name: Optional[str] = None
|
||||
description: Optional[str] = None
|
||||
credential_type: Optional[str] = None
|
||||
|
||||
# RouterOS credential fields
|
||||
username: Optional[str] = None
|
||||
password: Optional[str] = None
|
||||
|
||||
# SNMP v1/v2c credential fields
|
||||
community: Optional[str] = None
|
||||
|
||||
# SNMP v3 credential fields
|
||||
security_level: Optional[str] = None
|
||||
auth_protocol: Optional[str] = None
|
||||
auth_passphrase: Optional[str] = None
|
||||
priv_protocol: Optional[str] = None
|
||||
priv_passphrase: Optional[str] = None
|
||||
|
||||
@field_validator("name")
|
||||
@classmethod
|
||||
def validate_name(cls, v: Optional[str]) -> Optional[str]:
|
||||
if v is None:
|
||||
return v
|
||||
v = v.strip()
|
||||
if len(v) < 1 or len(v) > 255:
|
||||
raise ValueError("Profile name must be 1-255 characters")
|
||||
return v
|
||||
|
||||
@field_validator("credential_type")
|
||||
@classmethod
|
||||
def validate_credential_type(cls, v: Optional[str]) -> Optional[str]:
|
||||
if v is None:
|
||||
return v
|
||||
if v not in VALID_CREDENTIAL_TYPES:
|
||||
raise ValueError(
|
||||
f"credential_type must be one of: {', '.join(VALID_CREDENTIAL_TYPES)}"
|
||||
)
|
||||
return v
|
||||
|
||||
@model_validator(mode="after")
|
||||
def validate_credentials(self) -> "CredentialProfileUpdate":
|
||||
"""Validate credential fields only when credential_type or credential fields change."""
|
||||
# Collect which credential fields were provided
|
||||
cred_fields = {
|
||||
"username", "password", "community",
|
||||
"security_level", "auth_protocol", "auth_passphrase",
|
||||
"priv_protocol", "priv_passphrase",
|
||||
}
|
||||
has_cred_changes = any(getattr(self, f) is not None for f in cred_fields)
|
||||
|
||||
# Only validate if credential_type changes or credential fields are provided
|
||||
if not self.credential_type and not has_cred_changes:
|
||||
return self
|
||||
|
||||
# If credential_type is changing, validate completeness
|
||||
ct = self.credential_type
|
||||
if ct:
|
||||
if ct == "routeros":
|
||||
if not self.username:
|
||||
raise ValueError("username is required for routeros credentials")
|
||||
if not self.password:
|
||||
raise ValueError("password is required for routeros credentials")
|
||||
elif ct in ("snmp_v1", "snmp_v2c"):
|
||||
if not self.community:
|
||||
raise ValueError(f"community is required for {ct} credentials")
|
||||
elif ct == "snmp_v3":
|
||||
if not self.username:
|
||||
raise ValueError("username is required for snmp_v3 credentials")
|
||||
if not self.security_level:
|
||||
raise ValueError("security_level is required for snmp_v3 credentials")
|
||||
if self.security_level not in VALID_SECURITY_LEVELS:
|
||||
raise ValueError(
|
||||
f"security_level must be one of: {', '.join(VALID_SECURITY_LEVELS)}"
|
||||
)
|
||||
if "auth" in self.security_level and self.security_level != "no_auth_no_priv":
|
||||
if not self.auth_protocol:
|
||||
raise ValueError("auth_protocol is required for this security_level")
|
||||
if self.auth_protocol not in VALID_AUTH_PROTOCOLS:
|
||||
raise ValueError(
|
||||
f"auth_protocol must be one of: {', '.join(VALID_AUTH_PROTOCOLS)}"
|
||||
)
|
||||
if not self.auth_passphrase:
|
||||
raise ValueError("auth_passphrase is required for this security_level")
|
||||
if self.security_level == "auth_priv":
|
||||
if not self.priv_protocol:
|
||||
raise ValueError("priv_protocol is required for auth_priv")
|
||||
if self.priv_protocol not in VALID_PRIV_PROTOCOLS:
|
||||
raise ValueError(
|
||||
f"priv_protocol must be one of: {', '.join(VALID_PRIV_PROTOCOLS)}"
|
||||
)
|
||||
if not self.priv_passphrase:
|
||||
raise ValueError("priv_passphrase is required for auth_priv")
|
||||
|
||||
return self
|
||||
|
||||
|
||||
class CredentialProfileResponse(BaseModel):
|
||||
"""Credential profile response schema. NEVER includes credential fields."""
|
||||
|
||||
id: uuid.UUID
|
||||
name: str
|
||||
description: Optional[str] = None
|
||||
credential_type: str
|
||||
device_count: int = 0
|
||||
created_at: datetime
|
||||
updated_at: datetime
|
||||
|
||||
model_config = {"from_attributes": True}
|
||||
|
||||
|
||||
class CredentialProfileListResponse(BaseModel):
|
||||
"""List of credential profiles."""
|
||||
|
||||
profiles: list[CredentialProfileResponse]
|
||||
Reference in New Issue
Block a user